[Date Prev][Date Next][Thread Prev][Thread Next][Thread Index]

[XaraXtreme-commits] Commit Complete



Commit by  : alex
Repository : xara
Revision   : 1600
Date       : Sat Jul 29 17:00:39 BST 2006

Changed paths:
   M /Trunk/XaraLX/Kernel/node.cpp

Fix valgrind unitialized variable issue


Diff:
Index: Trunk/XaraLX/Kernel/node.cpp
===================================================================
--- Trunk/XaraLX/Kernel/node.cpp	(revision 1599)
+++ Trunk/XaraLX/Kernel/node.cpp	(revision 1600)
@@ -161,7 +161,8 @@
 Node::Node()
 {
 	Previous=Next=Child=Parent=NULL; 
-	Flags.Locked=Flags.Mangled=Flags.Marked=Flags.Selected=Flags.Renderable = FALSE;   
+	// Set OpPermission stuff here too as SetOpPermission does a GetOpPermission which otherwise reads an undefined value
+	Flags.Locked=Flags.Mangled=Flags.Marked=Flags.Selected=Flags.Renderable=Flags.OpPermission1=Flags.OpPermission2 = FALSE;   
 	Flags.SelectedChildren = FALSE;
 	SetOpPermission(PERMISSION_UNDEFINED);	
 	HiddenRefCnt = 0; 


Xara