Re: [XaraXtreme-dev] font patches

[Phil Martin <phil@xxxxxxxx>]

Martin Wuerthner wrote:

> In message <442A621F.90000@xxxxxxxx>
>          Phil Martin <phil@xxxxxxxx> wrote:
>
>  
>
> > Hi Martin,
> >
> > I've just checked your font patches into SVN. Sorry for the delay - we
> > were sorting out internal systems and responsibilities.
> >    
>
> Thanks. There are two minor problems with the new file 
> wxOil/ftfonts.h:
>
> First of all, it seems that the e-mail transfer has converted the line 
> endings from LF to CRLF. I think it would be better if the file was 
> changed to the standard LF line endings.
>  
OK, I will try to remember to normalise new contributed files from now 
on (using Scripts/normalise.pl).

> Secondly, the $Id$ marker was not updated. Do you have an auto-props 
> rule in .subversion/config to automatically set the required property 
> for each file that is added? If not, it needs to be set manually using
>  svn propset svn:keywords "Id" <file>
>  
I have no idea about auto-props rules, hopefully someone whether greater 
SVN experience can answer that but In the meantime I'll use the manual 
command.

Both things should be fixed now.

Phil