RE: [XaraXtreme-dev] File => Close crashes

["Gerry Iles" <GerryI@xxxxxxxx>]

Well, there is no Oil print view class.  The only other class in that
hierarchy is the RalphView (which was derived from ScreenView just like
ScreenCamView was).  The selected view is the view that the user is
currently working with, and as such, I don't think it has ever been
anything other than a kernel DocView that is attached to an Oil
ScreenCamView.

The kernel/oil divide makes things quite complex in this area but I do
still think that those checks are irrelevant and that the various
changes of selected view and document (kernel-side) aren't happening
correctly.

Gerry

-----Original Message-----
From: owner-dev@xxxxxxxxxxxxxxxx [mailto:owner-dev@xxxxxxxxxxxxxxxx] On
Behalf Of Alex Bligh
Sent: 05 April 2006 17:29
To: dev@xxxxxxxxxxxxxx
Cc: Alex Bligh
Subject: RE: [XaraXtreme-dev] File => Close crashes

But what was the original purpose of the IsScreenCamView check? I had
presumed distinguishing it from (say) a print view.

Alex

--On 05 April 2006 17:23 +0100 Gerry Iles <GerryI@xxxxxxxx> wrote:

> Yes, there used to be a class hierarchy:
>
> ScreenCamView
> ScreenView
> CCamView
> wxView/CView
>
> This was deemed pretty pointless so the top two classes were merged
into
> CCamView when I reorganised things a while back.  That test should now
> be totally redundant.
>
> I'm pretty certain that the selected document and view should be
> cleared, resulting in the various SELCHANGED messages being broadcast
> before the document and view get deleted and that this isn't happening
> for some reason.
>
> There should definitely never be any SELCHANGED type messages sent
> around where the old pointer points at something that has been deleted
> either notionally, or actually with delete.
>
> The fact that you can't seem to have more than one view visible at a
> time in the linux version hides a lot of the complexity of the view
> activation code e.g. when you switch view, the tools render the blobs
> off the old view but that is now behind the new view and doesn't
> actually redraw anything.
>
> Gerry
>
> -----Original Message-----
> From: owner-dev@xxxxxxxxxxxxxxxx [mailto:owner-dev@xxxxxxxxxxxxxxxx]
On
> Behalf Of Alex Bligh
> Sent: 05 April 2006 17:02
> To: dev@xxxxxxxxxxxxxx
> Cc: Alex Bligh
> Subject: RE: [XaraXtreme-dev] File => Close crashes
>
>
>
> --On 05 April 2006 16:57 +0100 Gerry Iles <GerryI@xxxxxxxx> wrote:
>
>> I don't think it has anything specifically to do with the call to
>> IsScreenCamView.
>
> IsScreenCamView doesn't exist any more for some reason (view class
> rearrangement I presume). I actually commented it out in more than
> one tool conversion, so it might be worth a quick grep for it.
>
> Alex
>
>