RE: [XaraXtreme-dev] Re: [XaraXtreme-commits] Commit Complete

["Gerry Iles" <GerryI@xxxxxxxx>]

Indeed... This is temporary test code while the plugin filter mechanism
is being implemented.  I didn't mean to check it in but it shouldn't
really affect anyone unless they try to export using the plugin filter.

It might cause issues for Phil and/or Luke (as the code that launches
the filter isn't complete) but the test filter will be available very
shortly and it should be pretty easy to stub out any bits that really
get in the way...

Gerry

-----Original Message-----
From: owner-dev@xxxxxxxxxxxxxxxx [mailto:owner-dev@xxxxxxxxxxxxxxxx] On
Behalf Of Alex Bligh
Sent: 08 May 2006 10:27
To: xara-dev
Cc: Alex Bligh
Subject: [XaraXtreme-dev] Re: [XaraXtreme-commits] Commit Complete

Gerry,

--On 08 May 2006 10:15 +0100 subversion@xxxxxxxxxxxxxx wrote:

> Commit by  : gerry
> Repository : xara
> Revision   : 972
> Date       : Mon May  8 10:15:25 BST 2006
>
> Changed paths:
>    M /Trunk/XaraLX/wxOil/camview.cpp
>    M /Trunk/XaraLX/wxOil/xpoilflt.cpp
>    M /Trunk/XaraLX/wxOil/xpoilflt.h
>
> Fixes for File/Close

I think you, urm, checked in rather too much there. Specifically
xpoilfilt.cpp, .h. Specifically, see below:

>
>
> Diff:
> Index: Trunk/XaraLX/wxOil/xpoilflt.cpp
> ===================================================================
> --- Trunk/XaraLX/wxOil/xpoilflt.cpp	(revision 971)
> +++ Trunk/XaraLX/wxOil/xpoilflt.cpp	(revision 972)
> @@ -774,6 +774,13 @@
>  		return(FALSE);
>  #endif
>
> +
>
m_FilterPath.SetPathName(_T("/home/gerry/src/XPFilter/debugu/XPFilter"))
;
> +
> +	// This should be set to some sensible path but I've hardcoded
it for
> now +	// We should change to making ~/.XaraLX into a directory and
store
> the main config +	// file and these filter config files in there
> +	m_XMLFile.SetPathName(_T("~/.XPFilters/XPFilter.xml"));
> +

Ummmm, what are we trying to do here? Taking it this is temporary.

Can't you read filter config from XaraLX preferences like everything
else? Or, if you want a separate preferences file, use a separate
wxPrefs invocation? Directories etc. are nasty. Hard coded paths
are nastier still.

Alex