RE: [XaraXtreme-dev] RE: [XaraXtreme-bugzilla] [Bug 1125] Bevel tool does not work properly on Text

["Gerry Iles" <GerryI@xxxxxxxx>]

Martin,

In fact, it appears that this override of IsCompound was present in r714
which was before any of your text handling stuff was added.

Anyone remember the error "LocaliseCommonAttributes called on
non-Compound Node" when doing things with text stories early on in the
port?

Gerry

-----Original Message-----
From: owner-dev@xxxxxxxxxxxxxxxx [mailto:owner-dev@xxxxxxxxxxxxxxxx] On
Behalf Of Gerry Iles
Sent: 04 July 2006 17:59
To: dev@xxxxxxxxxxxxxx
Subject: [XaraXtreme-dev] RE: [XaraXtreme-bugzilla] [Bug 1125] Bevel
tool does not work properly on Text

Martin,

Did you make this change when you were implementing the text handling?
Was it because of the error I mentioned?

Anyone have any idea off-hand why that error goes off in LX and not in
Xtreme when you are simply resizing a text story...?

Gerry

-----Original Message-----
From: owner-bugzilla@xxxxxxxxxxxxxxxx
[mailto:owner-bugzilla@xxxxxxxxxxxxxxxx] On Behalf Of
bugzilla-daemon@xxxxxxxxxxxxxxxx
Sent: 04 July 2006 17:53
To: bugzilla@xxxxxxxxxxxxxx
Subject: [XaraXtreme-bugzilla] [Bug 1125] Bevel tool does not work
properly on Text

http://bugzilla.xara.com/show_bug.cgi?id=1125





------- Additional Comments From gerry@xxxxxxxx  2006-07-04 17:53 BST
-------
This bug is caused by the fact that BaseTextClass has been changed in
XaraLX 
to override IsCompound and return TRUE.  This means that no suitable
nodes to 
copy the attributes from are found in OpCreateBevel::ApplyBevelToNode.

Obviously not all text Node classes should be compound but simply
removing the 
override causes all sorts of other things to not work (e.g. errors that 
LocaliseCommonAtttributes is called on a non-compound node).

Presumably this override was added to work around this error (and
possibly 
others) however this is not the correct way to fix that problem.  There
must 
be some other code that has been changed or PORTNOTEd during the port
that 
caused these problems and that needs to be found and fixed properly.

-- 
Configure bugmail: http://bugzilla.xara.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.