RE: [XaraXtreme-dev] RE: [XaraXtreme-bugzilla] [Bug 1125] Bevel tool does not work properly on Text

["Phil Martin" <Phil@xxxxxxxx>]

I encountered this when implementing LiveEffects in Xtreme and had to be
very careful about the use of IsCompound and I created IsCompoundClass
at this time to detect real compound nodes...

I think BaseTextClass used to return TRUE from IsCompound and thus so
did TextChar. If I remember correctly I changed that in Xtreme at the
time of implementing LiveEffects.

So if it still exists in LX it's a throwback/lost change.

FYI: in Xtreme now only NodeCompound, TextLine and TextStory return TRUE
from IsCompound.

Phil 

> -----Original Message-----
> From: owner-dev@xxxxxxxxxxxxxxxx 
> [mailto:owner-dev@xxxxxxxxxxxxxxxx] On Behalf Of Gerry Iles
> Sent: 04 July 2006 20:35
> To: dev@xxxxxxxxxxxxxx
> Subject: RE: [XaraXtreme-dev] RE: [XaraXtreme-bugzilla] [Bug 
> 1125] Bevel tool does not work properly on Text
> 
> Well, it might have been but the change makes no sense 
> conceptually.  A TextChar object is not a compound node and 
> never can be so any change that makes it so is fundamentally wrong...
> 
> I think it was either accidental (e.g. the function was 
> accidentally moved from the TextStory class) or not very well 
> considered due to unfamiliarity with the code...
> 
> Gerry
> 
> -----Original Message-----
> From: owner-dev@xxxxxxxxxxxxxxxx 
> [mailto:owner-dev@xxxxxxxxxxxxxxxx] On Behalf Of Alex Bligh
> Sent: 04 July 2006 18:49
> To: dev@xxxxxxxxxxxxxx
> Cc: Alex Bligh
> Subject: Re: [XaraXtreme-dev] RE: [XaraXtreme-bugzilla] [Bug 
> 1125] Bevel tool does not work properly on Text
> 
> Gerry Iles wrote:
> > Martin,
> > 
> > In fact, it appears that this override of IsCompound was present in
> r714
> > which was before any of your text handling stuff was added.
> > 
> > Anyone remember the error "LocaliseCommonAttributes called on 
> > non-Compound Node" when doing things with text stories 
> early on in the 
> > port?
> 
> I have better archaeology. It was thus on rev 385 of the very 
> first svn repository. It must have been a very early change 
> indeed. Which is most peculiar as r385 was nowhere near 
> rendering text.
> 
> Are you sure it was not at some stage converted to do that in 
> SourceSafe, someone took the patch over, then SourceSafe got 
> reverted but no-one carried the patch through to svn?
> 
> Alex
>